moderated Significant issue with the folder Move function #bug


Bruce Bowman
 

Mark -- When I click on the scissors icon for a folder in Files, this activates the Move function, displaying a dialog box with the entire Files directory structure. Included in that dialog are subfolders of the folder I'm trying to move.

If I click on one of these subfolders as the destination, that entire section of the directory structure collapses and disappears, along with all of its content.

It would be better if the displayed directory structure did not include subfolders of the one I clicked on to start the process.

FYI,
Bruce


Andy
 

If I click on one of these subfolders as the destination, that entire section of the directory structure collapses and disappears, along with all of its content.


Bruce, are you saying that you attempted to move a folder into one of its own subfolders?  I would guess that should not work.

When you click on a folder in the pop-up dialog box, it completes the move.  The pop-up dialog box should disappear at that point because it's done - except for the fact that you tried an illegal move.

IMO, it's cumbersome having the entire directory structure there all at once.  I wish there was a better way, more interactive.

Andy



Bruce Bowman
 

On Tue, Dec 7, 2021 at 09:00 PM, Andy wrote:
Bruce, are you saying that you attempted to move a folder into one of its own subfolders?
As a test, yes.

  I would guess that should not work.
I never expected it to "work"...but I didn't think it would fail in such a dramatic manner.

Bruce


Andy
 

I never expected it to "work"...but I didn't think it would fail in such a dramatic manner.

I'm not understanding what you mean by "fail in such a dramatic manner."  If you mean that the pop-up dialog box disappears, that is normal.  If you mean that it did not send you an error message, I guess you might be right about that (but I did not try it).

The normal operation of a "move" is that you click on your choice to move it to, the pop-up box disappears, and the move is completed.

So, I am wondering, what did you expect would happen when you clicked a destination folder?

FYI, I wouldn't really call it a "dialog box" because there is no dialog.  Were you expecting a dialog where it asks you, "Are you sure?" or something of that nature?

Andy


Bruce Bowman
 

On Wed, Dec 8, 2021 at 09:36 AM, Andy wrote:
I'm not understanding what you mean by "fail in such a dramatic manner."  If you mean that the pop-up dialog box disappears, that is normal.  If you mean that it did not send you an error message, I guess you might be right about that (but I did not try it).
I have in fact already explained this.

Bruce


Andy
 

I have in fact already explained this.

Not very well, I'm afraid.  You said that the  pop-up box disappears.  That's normal.  That is not a dramatic failure.  You said that this is a bug, but I don't think it is, because it's behaving normally when that happens.

It's sort of true that its display ought not to include directories into which the current one can not legitimately be moved.  What it's doing is just listing all of the directories and letting you choose the one you want.  It would indeed be better if it filtered the list of directories to not include ones that are not legitimate destinations.  Is THAT the thing you want Groups.io to do?  Or do you want it to react differently when you click on a destination directory?  Do you want there to be a dialog, instead of the pop-up window disappearing like it does now?  I'm just trying to understand what is the actual issue, because the description of "faili(ng) in such a dramatic manner" does not seem to match the reality that I see.

Andy


Duane
 

On Wed, Dec 8, 2021 at 10:13 AM, Andy wrote:
That is not a dramatic failure.  You said that this is a bug, but I don't think it is, because it's behaving normally when that happens.
Read Bruce's second paragraph:

"If I click on one of these subfolders as the destination, that entire section of the directory structure collapses and disappears, along with all of its content."

I'd definitely call loss of a folder (and any sub-folders/files in it) a dramatic failure.

Duane


Andy
 

"If I click on one of these subfolders as the destination, that entire section of the directory structure collapses and disappears, along with all of its content."

I'd definitely call loss of a folder (and any sub-folders/files in it) a dramatic failure.

Well that is an interesting question.

I paused for a moment when I first read it, but I did not interpret Bruce's statement as actually meaning that the folder and its sub-folders actually disappeared from the Files section.  If they did, that would indeed be a catastrophic failure (and further evidence that groups.io's file structure has serious integrity problems).  But I re-read Bruce's note a few times and (perhaps mistakenly) concluded that he meant that they disappeared from his screen when the pop-up window vanished, but that the files themselves were still intact.

I wonder, which was it?

If it was the folders and files themselves that disappeared, then that would be the thing to highlight - not the fact that the pop-up box collapses and disappears.  I find it hard to interpret which one he meant.  But maybe that's just me.

Andy


 

Hi All,

Yes, this is a serious bug, but no data has been lost. I have fixed it so that you can no longer move a folder into a subfolder of itself. If you try to do that, the action is now ignored.

What I need to do next is to go through the database looking for these 'folder loops' and then 'break' them. This will cause the folders to be displayed again in the Files section. Again, no data has been lost, it's just that these loops cause the code to become confused, and therefore not show the file structure.

Finally, I need to update the Move dialog UI to not show subfolders when moving a folder.

I hope to fix the existing folder loops in the database either later today or tomorrow. I'll post when that happens.

Thanks,
Mark


 

Hi All,

I've now completed the second step in fixing this bug; I've gone through the database and broken all existing file folder loops. There were 54 loops over 52 groups (from ~88k groups examined). For each loop, I took one of the folders and moved it to the top level of the Files section. I also appended "(recovered)" to the name of that folder.

Please let me know if you have any questions.

Thanks,
Mark


Andy
 

Finally, I need to update the Move dialog UI to not show subfolders when moving a folder.

Mark, when you wrote that, do you mean (when this step is completed) that it will no longer show any subfolders until clicked to open them?  Or do you mean not showing subfolders of the original folder being moved?

(I would be in favor of the former, because we have many folders and currently it's a real pain in the you-know-what to locate the target folder from the colossal list.  I'm not entirely sure what would really help with that - but having the UI not display every possible folder right off the bat, would probably be a step in the right direction.  That is really a separate issue.  I was just wondering which you meant to do.)

Andy


 


Bruce Bowman
 

On Thu, Dec 9, 2021 at 01:50 PM, Mark Fletcher wrote:
I've now completed the second step in fixing this bug; I've gone through the database and broken all existing file folder loops. There were 54 loops over 52 groups (from ~88k groups examined). For each loop, I took one of the folders and moved it to the top level of the Files section. I also appended "(recovered)" to the name of that folder.
Mark -- At this time I cannot move any subfolders to the top level.

FYI,
Bruce


 

On Thu, Dec 9, 2021 at 3:08 PM Bruce Bowman <bruce.bowman@...> wrote:

Mark -- At this time I cannot move any subfolders to the top level.


This should be fixed.

Thanks,
Mark