On Tue, May 2, 2023 at 02:56 PM, Mark Fletcher wrote:

I just pushed a series of improvements to the pending message page.

Hi Mark,

Hmm. I would debate use of the word 'improvement' at this point:

• On the pending messages screen we have a Red reject button which when selected gives the reject dialog with a Blue reject button
• When viewing a pending message and using the Red reject button, the dialog gives two options; reject with a message and reject without a message. Reject without a message invokes the delete process and requires a further confirmation but reject with a message does not require a further confirmation. So, there are now two call to action buttons with different text in different locations that invoke the delete process.
• The options around the sender are not immediately obvious and don't seem consistent with other options on the site. I was quite happy with individual buttons as they were but if they do need to move, perhaps they could be made more obvious by placing an Actions button next to the member name with the options available from that like they are from the member list.  The text for these functions should be consistent with that on other Actions buttons too.  For example, the drop down list here just says 'Ban' but the same function on the Actions button on the member list says 'Ban sender'. The use of icons for these functions could be consistent too which I think may also make life easier for those where English is not their first language.

Regards
Andy

I'm unclear what "reject without message" does. Rejects the message with no note from the moderator, or rejects the message without their original pending message attached? And what exactly is the purpose of this change?
Also, the option to email the member from the pending message seems to have disappeared. I use this function very very often, to connect with the member about their post without rejecting it. Can you please bring that back (right away if possible? - I already need it for 3 messages that are waiting).
Thank you, Sally

On Tue, May 2, 2023 at 05:37 PM, Niman H wrote:

the option to email the member from the pending message seems to have disappeared

The option to send a message to a member is still there. When you are viewing a message from a member, look for the small drop-down arrow next to the member name.  I have suggested putting an Actions button here to make it more obvious.

Regards
Andy

On Tue, May 2, 2023 at 05:37 PM, Niman H wrote:

Can you please bring that back (right away if possible? - I already need it for 3 messages that are waiting).

It's still there; use the drop - down beside the member's Display Name

Chris 

On Tue, May 2, 2023 at 04:55 PM, Mark Fletcher wrote:

I think you mean the secondary confirmation dialog for deleting a message, which had a blue `Yes` button. I've changed that to red.

No. On the pending message list, check the box next to a message and then use the red reject button. On the reject dialog that opens, the reject button is blue.

Should I add a second confirmation step to the `reject with message` flow, or should I remove the second confirm step for the `reject without message` flow?

Should I add a second confirmation step to the `reject with message` flow, or should I remove the second confirm step for the `reject without message` flow?

My suggestion would be to add it to the `reject with message` flow as well.  Since the with and without buttons are both red and are situated right next to each other, it may be easier now for someone in a rush to accidentally click on the wrong one, so that second confirmation step gives you some insurance against "oh-no seconds" like that.

Cheers,
Christos

On Tue, May 2, 2023 at 06:10 PM, Christos Psarras wrote:

My suggestion would be to add it to the `reject with message` flow as well.  Since the with and without buttons are both red and are situated right next to each other, it may be easier now for someone in a rush to accidentally click on the wrong one, so that second confirmation step gives you some insurance against "oh-no seconds" like that.

but in order to get to the dialog where you have both buttons, you have already had to select a Reject button. I would argue that the dialog where can type a message is the confirmation.  I don't need three actions to reject or delete a message.

Regards
Andy

I like the streamlined look, and I agree with others, some improved Sender Actions dropdown visibility could help.

I'm personally glad the "Approve & Unmoderate Sender" button is gone from this view, although it's still there in the pending messages list; displaying that button always, regardless of group moderation status, has caused confusion in the past to new mods.

Cheers,
Christos

On Tue, May 2, 2023 at 06:10 PM, Christos Psarras wrote:

My suggestion would be to add it to the `reject with message` flow as well.  Since the with and without buttons are both red and are situated right next to each other, it may be easier now for someone in a rush to accidentally click on the wrong one, so that second confirmation step gives you some insurance against "oh-no seconds" like that.

but in order to get to the dialog where you have both buttons, you have already had to select a Reject button. I would argue that the dialog where can type a message is the confirmation.  I don't need three actions to reject or delete a message.

The first click doesn't really count, it just brings up the submenu; in there, one can type a message but accidentally hit the 'Reject without message' button and more than likely they would lose what they had just typed, if there wasn't the second confirmation dialog.

Cheers,
Christos

On Tue, May 2, 2023 at 06:33 PM, Christos Psarras wrote:

The first click doesn't really count,

Of course it does. It's a required action to start the process.

Regards
Andy

On Tue, May 2, 2023 at 06:58 PM, Mark Fletcher wrote:

That's the delete message function. I renamed it because I was hoping the new name would be more descriptive. Should I change it to something else, like 'Delete'?

Having a button that says Delete that you can correlate with an activity log message saying the same thing seems to make more sense a button called Reject without a message.

Regards
Andy

On Tue, May 2, 2023 at 10:58 AM, Mark Fletcher wrote:

Should I change it to something else, like 'Delete'?

Haha, yes! "Delete"! What a great idea. :-)
 
--
J

Messages are the sole opinion of the author, especially the fishy ones.
My humanity is bound up in yours, for we can only be human together. - Desmond Tutu

👍👏

On Tue, May 2, 2023 at 05:56 PM, Andy Wedge wrote:

On Tue, May 2, 2023 at 04:55 PM, Mark Fletcher wrote:

I think you mean the secondary confirmation dialog for deleting a message, which had a blue `Yes` button. I've changed that to red.

No. On the pending message list, check the box next to a message and then use the red reject button. On the reject dialog that opens, the reject button is blue.

And this Reject button is staying blue?



Regards
Andy

On Tue, May 2, 2023 at 03:56 PM, Mark Fletcher wrote:

I have combined the various approve and
reject/delete functions so that there are now just Approve and Reject
buttons that bring up dialogs with the appropriate options.

What is a "dialog" (other than a conversation between two people, obviously) ?

groetjes/ĝis, Ronaldo