On 17/02/2021 22:44:18, Malcolm Austen <malcolm.austen@...> wrote:

Thanks Mark, I will give it a proper look, with some varying settings of time zones, tomorrow.

On a very quick look, it seems good. I have two comments though ...

1. for 'all day' events, you are showing the time (as 00:00) which wasn't shown before and probably should not be showing now.

2. the new coding still ignores my preference setting for the date display. This is unchanged from before so may be intended? If it is intended, I will submit it as a separate bug :-)

Malcolm.

-- 

Malcolm Austen <malcolm.austen@...>

On 17/02/2021 21:00:15, Mark Fletcher <markf@corp.groups.io> wrote:

Hello,

I've made some substantial changes in both how our javascript helper files are delivered as well as the code to display the actual event times. Please let me know if that fixes the problem.

Thanks,

Mark

On 17/02/2021 21:00:15, Mark Fletcher <markf@corp.groups.io> wrote:

Hello,

I've made some substantial changes in both how our javascript helper files are delivered as well as the code to display the actual event times. Please let me know if that fixes the problem.

Thanks,

Mark

On 12/12/2020 04:48:36, Mark Fletcher <markf@corp.groups.io> wrote:

On Thu, Dec 3, 2020 at 12:40 PM Malcolm Austen <malcolm.austen@...> wrote:

At risk of making a fool of myself, I think I have spotted it as a bug in https://groups.io/js/displaytime-0.2.6.js

function DisplayEventTime(t, tzstr, dateFormat, timeFormat) {
    if (t == 0) {
        return '';
    }
    if (typeof tzstr === 'undefined' || tzstr == '') {
        tzstr = '';
        momentDay = moment(t);
    } else {
        momentDay = moment(t).tz(tzstr);
<snip>

should, I suspect, have that last line before the snip as                  momentDay = moment.tz(t,tzstr)
- that's what the matching line looks like in the other, similar functions in that file.

You might be right. I've been unable to reproduce the bug, try as I might. I've made the change to this line of code, please let me know if it fixes the problem for you. You may need to do a force reload; hold down the shift key while clicking the browser refresh button.

Thanks,

Mark

On 14/01/2021 21:58:00, Mark Fletcher <markf@corp.groups.io> wrote:

Hello,

This has been fixed now. You may need to do a force reload (hold down the shift key while clicking the browser reload button).

Thanks,

Mark